Open
Conversation
drossetti
requested changes
May 22, 2017
| /* | ||
| * GPUDirect Async latency benchmark | ||
| * | ||
| * |
Contributor
There was a problem hiding this comment.
could you please address whitespace issues in a different pull req ?
| if (!ctx->ah) { | ||
| fprintf(stderr, "Failed to create AH\n"); | ||
| return 1; | ||
| union ibv_gid dgid; |
Contributor
There was a problem hiding this comment.
you could add a comment describing this fallback code.
e.g.. "this code is required for RoCE V1 and/or V2 blabla"
Contributor
There was a problem hiding this comment.
@ferasd could you please review this change ?
as a context, it is required to run this test in RoCE mode.
| if (!ctx->ah) { | ||
| fprintf(stderr, "Failed to create AH\n"); | ||
| return 1; | ||
| ah_attr.is_global = 1; |
Contributor
There was a problem hiding this comment.
as before, add a comment here
Contributor
|
@ksang I'm going to integrate the cleaup branch into devel. can you please rebase this change on that other branch or wait ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #10
Only tested loopback test as I don't have env for MPI test running on two nodes.